observability: include exception class in retry log lines#64
Open
rmfan wants to merge 1 commit into
Open
Conversation
httpx transport-level exceptions (RemoteProtocolError, ConnectError,
PoolTimeout, ConnectTimeout) stringify to "" — the current retry logs
render as `Error: , retrying...` with no discriminating information.
Adding `{type(e).__name__}` unblocks classification without changing
behavior.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Include
{type(e).__name__}in retry log lines that currently render{e}verbatim.Why
httpx transport-level exceptions (
RemoteProtocolError,ConnectError,PoolTimeout,ConnectTimeout) all stringify to an empty string. Current logs render asError: , retrying...— no way to discriminate failure classes.No behavior change — pure log format.
🤖 Generated with Claude Code